Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename countries to regions. #465

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Rename countries to regions. #465

merged 2 commits into from
Aug 15, 2023

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Apr 21, 2023

@fiatjaf
Copy link
Member

fiatjaf commented Apr 21, 2023

Looks good to me, but we must hear from the people who may be using this.

@motorina0
Copy link
Contributor

How can we coordinate with other users/interested parties of NIP15?
Chances that they will see this PR are slim.

Are there telegram channels per NIP now? :)

@ekzyis
Copy link

ekzyis commented Apr 22, 2023

I think location would be better since it's more generic than region and country. This was mentioned by @ghost here: #461 (comment)

@ibz
Copy link
Contributor Author

ibz commented Apr 22, 2023

I think region is more generic than location. You can call Paris a region (although it is a small region) but you can't call some bigger region, like France or the EU a location. location is ways very local, hence the name.

@ibz
Copy link
Contributor Author

ibz commented Aug 14, 2023

@motorina0 We finally have a Telegram channel for NIP-15! Should I ask there as well?

@motorina0
Copy link
Contributor

@motorina0 We finally have a Telegram channel for NIP-15! Should I ask there as well?

For whoever might be concerned:

Channel: https://t.me/+praQQFXCDiFlZGJk

@fiatjaf fiatjaf merged commit 88ee873 into nostr-protocol:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants