Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the t tag in NIP-24 #1428

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

alexgleason
Copy link
Member

No description provided.

Copy link
Member

@staab staab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change, but is lowercasing the only normalization we want to do? I think yes, but would more aggressive slugification make sense?

@vitorpamplona
Copy link
Collaborator

Lowercase is good. I am not sure about the requirement to have the tags listed in content as well. Sounds like overkill.

@alexgleason
Copy link
Member Author

alexgleason commented Aug 16, 2024

@vitorpamplona The only time I've seen t tags with no hashtag in the text is spam. Blocking that blocked a lot of spam. I'm not sure there's a legitimate reason to have invisible hashtags in a note.

EDIT: See: https://gitlab.com/soapbox-pub/gleasonator-policy/-/blob/main/policies/InvisibleHashtagPolicy.ts

@vitorpamplona
Copy link
Collaborator

Kind 1s have hidden tags all the time. I know because Amethyst displays hidden tags in an extra section below the post. I don't know which client creates them, but it is fairly common.

@fiatjaf
Copy link
Member

fiatjaf commented Aug 16, 2024

I feel like having t tags without the corresponding text is a legitimate use case, but in practice I don't know how it would work because I never use them, so I'm ok with trying to remove that practice from earth.

I guess if you're forced to put the tags in the text it makes it clear that you're trying to spam topics if you are.

@dluvian
Copy link
Contributor

dluvian commented Aug 17, 2024

Voyage lets you set these hidden hashtags and I use them all the time. Writing hashtags in the content is ugly imo and setting them only in the metadata to improve discoverability should not be discouraged.

If the goal is to prevent spam I would set a limit on the number of t tags.

@alexgleason
Copy link
Member Author

Alright, I modified it. Now it just says:

  • t: a hashtag. The value MUST be a lowercase string.

@alexgleason alexgleason merged commit d0962aa into nostr-protocol:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants