feat: switch from scss to postcss #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
added
design
website redesign
github-actions
bot
removed
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
AugustinMauroy
approved these changes
Sep 23, 2023
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
commented
Sep 23, 2023
Signed-off-by: Claudio W <[email protected]>
ovflowd
commented
Sep 23, 2023
ovflowd
commented
Sep 23, 2023
github-actions
bot
removed
the
github_actions:pull-request
bmuenzenmeyer
approved these changes
Sep 24, 2023
Signed-off-by: Brian Muenzenmeyer <[email protected]>
MattIPv4
reviewed
Sep 24, 2023
MattIPv4
approved these changes
Sep 24, 2023
github-actions
bot
removed
the
github_actions:pull-request
|
@bmuenzenmeyer and @MattIPv4 if you two don't mind, could y'all give a last copy-check on the changes? I've just pushed some changes to simplify and better some docs |
✅ looking good to me |
Harkunwar
approved these changes
Sep 24, 2023
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To simplify the stack of the Node.js Website, I've decided to remove support for SASS/SCSS from this repository.
This is because all our styles were processed at least 3 times. (Sass -> PostCSS -> CSS -> Minification)
Introducing Tailwind would also create inconsistencies, as we use custom Tailwind "syntax" such as
@tailwind,@applyandtheme.The SASS/SCSS processor also includes a lot of extra things that we don't necessarily need;
By switching to PostCSS, we wanted to retain a SCSS-alike syntax, such as supporting Mixins, Variables, Nesting, and more. This PR also adds relevant plugins although it is important to mention that the only significant difference is how
mixinswork with PostCSS.The benefits of PostCSS include a lighter CSS footprint, faster compilation times, less verbose, and the support of a subset of functionalities (plugins) we like.
Differences in Mixins
In SCSS, you define a Mixin with
@mixin, and if you have variables, you define them as$variable; With PostCSS, you define a Mixin with@define-mixin, and variables do not need the$.In SCSS, you consume a Mixin with
@include. In PostCSS, you consume a Mixin with@mixin.What changed in this PR?
*.scssto.csspreview.tsx, fixing styles, types, and other thingsWhy so many changes?
Some changes are partially unrelated to the migration from SCSS to PostCSS (mainly the Storybook changes); they're added in this PR primarily for convenience and to address these stylistic changes in a single batch.
Validation
Storybooks, Builds, and Local Development should work as expected.