Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-post script breaks if there is a line after a header link #837

Closed
evanlucas opened this issue Jul 22, 2016 · 1 comment
Closed

release-post script breaks if there is a line after a header link #837

evanlucas opened this issue Jul 22, 2016 · 1 comment

Comments

@evanlucas
Copy link
Contributor

If there is a line after the <a id="6.3.1"></a> header link in node changelogs, the release-post script breaks
@lpinca
Copy link
Member

lpinca commented Jul 22, 2016 •
edited
Loading

The problem is in these two regex 1, 2. The second one does not match as there is a leading \n.
I think the beast approach to fix this is to trim the matched section.

lpinca added a commit that referenced this issue Jul 22, 2016
@lpinca
Make the release-post script more tolerant
cdfe139 
Fixes: #837
@lpinca lpinca mentioned this issue Aug 8, 2016
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanlucas @lpinca