Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark dgram-multicast-multi-process as flaky on v0.12 #9150

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 18, 2016

This has been consistently failing for a while now on some Windows setups, always making interpreting CI annoying.

Note this is v0.12!

/cc @nodejs/testing

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v0.12 labels Oct 18, 2016
@rvagg
Copy link
Member Author

rvagg commented Oct 18, 2016

CI @ https://ci.nodejs.org/job/node-test-commit/5653/ with one dgram-multicast-multi-process failure in there that's flaky so we have a passing Windows!

@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Oct 18, 2016
@joaocgreis
Copy link
Member

LGTM

The test passes on my machine, the CI timeout is most likely a CI problem. I'll investigate. For now, marking as flaky is the right thing to do.

@Trott
Copy link
Member

Trott commented Oct 18, 2016

Nit: If it's only flaky on Windows, maybe create a Windows-only section (with [$system==win32]) and mark it flaky there.

rvagg added a commit that referenced this pull request Oct 29, 2016
@rvagg rvagg closed this Oct 29, 2016
@rvagg rvagg deleted the test-dgram-multicast-multi-process-flaky-0.12 branch October 29, 2016 07:10
@rvagg
Copy link
Member Author

rvagg commented Oct 29, 2016

landed @ d8e27ec

@Trott I actually did just that on my local copy but forgot to push to this PR, true story!

jBarz pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants