Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add cluster inspector debug port test #8958

Merged
merged 1 commit into from
Oct 10, 2016
Merged

test: add cluster inspector debug port test #8958

merged 1 commit into from
Oct 10, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 6, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This commit adds a test for the debug port value in cluster workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2016
@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. inspector Issues and PRs related to the V8 inspector protocol labels Oct 6, 2016
jasnell
jasnell approved these changes Oct 6, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Oct 7, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 10, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4444/

@cjihrig
test: add cluster inspector debug port test
2aa2f85 
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.

Refs: nodejs#8201
Refs: nodejs#8386
Refs: nodejs#8550
PR-URL: nodejs#8958
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
@cjihrig cjihrig merged commit 2aa2f85 into nodejs:master Oct 10, 2016
@cjihrig cjihrig deleted the test branch October 10, 2016 15:38
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@cjihrig @jasnell
test: add cluster inspector debug port test
96faba6 
This commit adds a test for the debug port value in cluster
workers using the inspector debugger.

Refs: #8201
Refs: #8386
Refs: #8550
PR-URL: #8958
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ilkka Myller <[email protected]>
@Fishrock123
Copy link
Contributor

depends on #8386

@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@imyller imyller imyller approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @Fishrock123 @bnoordhuis @jasnell @imyller @mscdex @nodejs-github-bot