Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix check of buffer and rearrange conditional #8739

Closed
wants to merge 2 commits into from
Closed

buffer: fix check of buffer and rearrange conditional #8739

wants to merge 2 commits into from

Commits on Sep 23, 2016

  1. buffer: fix check of buffer and rearrange conditional 

    isSharedArrayBuffer in fromObject was missing obj.buffer
moved the 'length' in obj check so that it is checked first making
the code slightly more performant and able to handle SharedArrayBuffer
without relying on an explicit check.
    @ojss
    ojss committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    1170309 View commit details
    Browse the repository at this point in the history

  2. test: add check for a particular codepath 

    ensure that Buffer.from works when argument is in the from
'{buffer: SharedArrayBuffer}'
    @ojss
    ojss committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    7f735d4 View commit details
    Browse the repository at this point in the history