doc: fix example in repl documentation about context properties #8469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
LGTM, thanks! It would be perfect if you could amend the commit’s subject line so that it’s not longer than 50 characters? |
We want to define the context property r.context.m, not r.m.
fhinkel
force-pushed
the
repl_documentation
branch
from
6d7826f
to
24a3e10
Compare
|
Forgot about that. Done! |
|
LGTM |
1 similar comment
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Sep 12, 2016
Define the context property r.context.m, not r.m. PR-URL: #8469 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 73b0182 |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Define the context property r.context.m, not r.m. PR-URL: #8469 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
doc
Description of change
Fix an example in the repl documentation that explains how to set context properties.
We want to define the context property
repl.context.m, notrepl.m.