src: updating references to the old node.js file #8092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node.js script was renamed to bootstrap_node.js as part of 81b6882. When I did this I missed several comments in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file.
nodejs-github-bot
added
the
c++
|
|
||
| // We start the process this way in order to be more modular. Developers | ||
| // who do not like how 'src/node.js' setups the module system but do like | ||
| // Node's I/O bindings may want to replace 'f' with their own function. | ||
| // who do not like how 'lib/internal/bootstrap_node.js' setups the module |
There was a problem hiding this comment.
Perhaps putting the full path here is unnecessary since the filename itself isn't ambiguous?
There was a problem hiding this comment.
Sounds good, I'll remove the path.
| CHECK(f_value->IsFunction()); | ||
| Local<Function> f = Local<Function>::Cast(f_value); | ||
|
|
||
| // Now we call 'f' with the 'process' variable that we've built up with | ||
| // all our bindings. Inside node.js we'll take care of assigning things to | ||
| // their places. | ||
| // all our bindings. Inside bootstrap_node.js we'll take care of |
There was a problem hiding this comment.
Should be "internal/bootstrap_node.js".
There was a problem hiding this comment.
I don't think it's necessary to put the full path
|
lgtm |
|
LGTM |
1 similar comment
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 18, 2016
The node.js script was renamed to bootstrap_node.js as part of 81b6882. Several comments were missed in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file. PR-URL: #8092 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0441f2a |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
The node.js script was renamed to bootstrap_node.js as part of 81b6882. Several comments were missed in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file. PR-URL: #8092 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
The node.js script was renamed to bootstrap_node.js as part of
81b6882. When I did this I missed
several comments in src/node.cc that referred to the old file name.
This commit updates the comments to refer to bootstrap_node.js and
correct the path to this file where used.
It also moves a comment that seems to have drifted in the file.