doc: fix typos in event loop doc to aid readability #6916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos.
|
LGTM. cc @jasnell - especially for style of language. |
| The order in which they are executed varies depending on the context in | ||
| which they are called. If both are called in the main module, then you | ||
| are bound by how fast your process goes (which is impacted by other | ||
| programs running on your machine). |
There was a problem hiding this comment.
Would prefer to rework this a bit to avoid the use of you and your. Perhaps...
The order in which the timers are executed will vary depending on the context
in which they are called. If both are called from within the main module, then timing
will be bound by the performance of the process (which can be impacted by other
applications running on the machine).
Or something along those lines.
|
@kevmannn can you remove the unrelated commits from the branch please? |
Use 'the process' instead of 'your process'.
|
@eljefedelrodeodeljefe 😰 Yep - done. |
|
Commit message doesnt meet the standard mentioned in the contributing guidelines I guess. Apart from that LGTM. Can you squash the commits please? |
eljefedelrodeodeljefe
pushed a commit
that referenced
this pull request
May 24, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: #6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
|
I went ahead and formatted this for you. I believe it is you first time contribution here right? Landed in af61ebf. |
|
Thanks @eljefedelrodeodeljefe - (well one of the first) |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: nodejs#6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: #6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 3, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: #6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: #6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Typos in the `setTimeout` vs. `setImmediate` section were hindering readability. Fixed these typos. PR-URL: #6916 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Robert Jefe Lindstaedt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Typos in the
setTimeoutvs.setImmediatesection were hinderingreadability. Fixed these typos.