Buffer bug fix #6775
Buffer bug fix #6775
Conversation
…rror on Buffer creation
nodejs-github-bot
added
the
buffer
|
@nodejs/buffer |
| @@ -749,6 +749,11 @@ for (let i = 0; i < 256; i++) { | |||
| assert.equal(hexb2[i], hexb[i]); | |||
| } | |||
|
|
|||
| //#6770 Test single hex character throws TypeError | |||
There was a problem hiding this comment.
You can reference github issues in comments, but it is usually preferred to give the full URL for things like that so that it’s easier to look up and there is no ambiguity wrt the old issue tracker at https://github.com/nodejs/node-v0.x-archive/
|
Slightly related #3773 |
|
Should be good to go I think |
| }, TypeError); | ||
|
|
||
| // Test single base64 char encodes as 0 | ||
| assert.equal(Buffer.from('A', 'base64'), 0); |
There was a problem hiding this comment.
This should use assert.strictEqual and should test the length of the buffer rather than the buffer itself.
|
LGTM… CI: https://ci.nodejs.org/job/node-test-commit/3437/ @Crazometer btw, Github doesn’t send out notifications when somebody pushes new commits to a PR, so posting a quick comment helps to make sure noething gets lost :) |
|
@addaleax Thanks for that, you could read my mind |
|
CI is green. You author name in this commit is given as “Crazometer”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
|
"Justin Sprigg" if you could thanks. I'll make sure to change that next time. |
Fixes single digit hex strings not raising TypeError on Buffer creation. Fixes: #6770 PR-URL: #6775 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 05e2acb. Thanks for fixing this! |
Fixes single digit hex strings not raising TypeError on Buffer creation. Fixes: #6770 PR-URL: #6775 Reviewed-By: Anna Henningsen <[email protected]>
Fixes single digit hex strings not raising TypeError on Buffer creation. Fixes: #6770 PR-URL: #6775 Reviewed-By: Anna Henningsen <[email protected]>
|
I'm assuming this doesn't affect the v4.x buffer system /cc @jasnell |
Checklist
masterAffected core subsystem(s)
Buffer
Description of change
Fixes #6770, Single digit hex strings not raising TypeError on Buffer creation