doc: update "who to cc in issues" chart #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | `lib/child_process` | @cjihrig, @bnoordhuis | | ||
| | `lib/cluster` | @cjihrig, @bnoordhuis | | ||
| | `lib/assert` | @Trott | | ||
| | `lib/buffer` | @trevnorris, @nodejs/buffer | |
There was a problem hiding this comment.
@trevnorris ∈ @nodejs/buffer :)
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
0b99265
to
4746b8e
Compare
| | `lib/{_}http{*}` | @indutny, @bnoordhuis, @mscdex, @nodejs/http | | ||
| | `lib/net` | @indutny, @bnoordhuis, @nodejs/streams | | ||
| | `lib/fs`, `src/{fs|file}` | @bnoordhuis, @jasnell, @saghul, @trevnorris | | ||
| | `lib/{_}http{*}` | @bnoordhuis, @indutny, @mscdex, @nodejs/http | |
There was a problem hiding this comment.
s/@mscdex//
I am already in in nodejs/http
There was a problem hiding this comment.
As is @indutny ... I can add @bnoordhuis to it right now also
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
4746b8e
to
92c48a9
Compare
| | `lib/{crypto,tls,https}` | @nodejs/crypto | | ||
| | `lib/domains` | @misterdjules | | ||
| | `lib/{_}http{*}` | @indutny, @bnoordhuis, @mscdex, @nodejs/http | | ||
| | `lib/net` | @indutny, @bnoordhuis, @nodejs/streams | | ||
| | `lib/fs`, `src/{fs|file}` | @bnoordhuis, @jasnell, @saghul, @trevnorris | |
There was a problem hiding this comment.
I have created the nodejs/fs team with these initial members
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
92c48a9
to
2c7251b
Compare
| | upgrading npm | @thealphanerd, @fishrock123 | | ||
| | upgrading v8 | @nodejs/v8, @nodejs/post-mortem | | ||
| | upgrading npm | @fishrock123, @thealphanerd | | ||
| | upgrading c-ares | @jbergstroem, @nodejs/http | |
There was a problem hiding this comment.
(we store it as deps/cares)
Hopefully we can use this as part of the bot at some stage?
There was a problem hiding this comment.
I've been thinking we could re-use the bot's logic for resolving PR labels, for /cc-ing as well. Who to /cc for which label could be read from this file.
|
We could add @nodejs/platform-windows for tools/msvs/* (mostly for the MSI). |
|
LGTM once the c-ares/http error on line 25 is fixed and nodejs/http is added to line 26 (http-parser). IMO, other nits/comments can be addressed now or in subsequent PRs. Fine by me either way. |
|
Feel free to add me to the |
addaleax
added
the
meta
|
@Fishrock123 ping |
|
@Fishrock123 want me to take this over? |
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
2c7251b
to
2e99bbd
Compare
|
Updated, LGTEveryone? |
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
2e99bbd
to
451c1f8
Compare
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
@RReverser Looks like this PR already updates the who-to-cc for buffer to the correct group. |
|
@Trott. Great! LGTM. |
Refs: nodejs#6655 PR-URL: nodejs#6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Fishrock123
force-pushed
the
doc/subsystem-teams
branch
from
451c1f8
to
f5cddad
Compare
Fishrock123
added a commit
that referenced
this pull request
Jun 27, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
Fishrock123
added a commit
that referenced
this pull request
Jul 5, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Refs: #6655 PR-URL: #6694 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ingvar Stepanyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
See #6655
@nodejs/collaborators please let us know if you think you should be listed here or not.