Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix exec example in child_process #6660

Merged
merged 1 commit into from
May 13, 2016
Merged

Conversation

evanlucas
Copy link
Contributor

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 9, 2016
@MylesBorins
Copy link
Contributor

LGTM

1 similar comment
@whitlockjc
Copy link
Contributor

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label May 9, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: nodejs#6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
@evanlucas evanlucas closed this May 13, 2016
@evanlucas evanlucas deleted the cpdocissue branch May 13, 2016 13:11
@evanlucas evanlucas merged commit d13b9d3 into nodejs:master May 13, 2016
@evanlucas
Copy link
Contributor Author

Landed in d13b9d3. Thanks!

evanlucas added a commit that referenced this pull request May 17, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: #6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: #6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: #6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: #6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Previously, the example was checking for error by strict equality to
null. The error could be undefined though which would fail that check.

PR-URL: #6660
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Jeremy Whitlock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants