Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove deprecated internal functions #6053

Merged
merged 1 commit into from
Apr 5, 2016
Merged

src: remove deprecated internal functions #6053

merged 1 commit into from
Apr 5, 2016

Conversation

bnoordhuis
Copy link
Member

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

src

Description of change

  • src: remove deprecated internal functions

CI: https://ci.nodejs.org/job/node-test-pull-request/2158/

@mscdex mscdex added lib / src Issues and PRs related to general changes in the lib or src directory. c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. labels Apr 5, 2016
@benjamingr
Copy link
Member

This is for 6.0?

LGTM I guess, pretty straightforward changes :)

@cjihrig
Copy link
Contributor

cjihrig commented Apr 5, 2016

LGTM and CI is green.

@jasnell
Copy link
Member

jasnell commented Apr 5, 2016

LGTM

@bnoordhuis
src: remove deprecated internal functions
757fbac 
PR-URL: nodejs#6053
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis bnoordhuis force-pushed the remove-deprecated-internal-functions branch from 21986a5 to 757fbac Compare April 5, 2016 14:21
@bnoordhuis bnoordhuis closed this Apr 5, 2016
@bnoordhuis bnoordhuis deleted the remove-deprecated-internal-functions branch April 5, 2016 14:21
@bnoordhuis bnoordhuis merged commit 757fbac into nodejs:master Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @benjamingr @cjihrig @jasnell @mscdex