Revert https://github.com/nodejs/node/pull/5776 #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
stream
|
LGTM, it would break things again on windows, but we need to assess the situation better. cc @piranna |
|
@egoroof I didn't imply otherwise, sorry if I was misunderstood. |
|
LGTM |
|
LGTM |
This reverts commit ace1009. The offending commit broke certain usages of piping from stdin. Fixes: nodejs#5927 PR-URL: nodejs#5947 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This reverts commit 4611389. The offending commit broke certain usages of piping from stdin. Fixes: nodejs#5927 PR-URL: nodejs#5947 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Alexis Campailla <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
stream, win
Description of change
Revert #5776
See #5927