Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix typos #55064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: fix typos #55064

wants to merge 1 commit into from

Conversation

NathanBaulch
Copy link

Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).

Use the following command to get a quick summary of the specific corrections made:

git diff HEAD^! --word-diff-regex='\w+' -U0 \
  | grep -E '\[\-.*\-\]\{\+.*\+\}' \
  | sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
  | sort | uniq -c | sort -n

FWIW, the typos are:

  • convertables
  • colum
  • registerd
  • endpont
  • iteratable
  • verion
  • exract
  • igoring
  • indentifier
  • inhert
  • malcious
  • maximimum
  • overlayed
  • postion
  • preivous
  • satisify
  • versons
  • wich

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 22, 2024
@@ -624,7 +624,7 @@ void Endpoint::InitPerContext(Realm* realm, Local<Object> target) {
#undef V

#define V(name, _) IDX_STATS_ENDPOINT_##name,
enum IDX_STATS_ENDPONT { ENDPOINT_STATS(V) IDX_STATS_ENDPOINT_COUNT };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell is this ok? I can't find a reference to this anywhere else.

Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (cfe58cf) to head (4034ead).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/tracing/trace_event.h 50.00% 2 Missing ⚠️
src/quic/endpoint.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55064   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         652      652           
  Lines      183912   183911    -1     
  Branches    35865    35870    +5     
=======================================
+ Hits       162272   162281    +9     
+ Misses      14915    14911    -4     
+ Partials     6725     6719    -6     
Files with missing lines Coverage Δ
src/aliased_buffer.h 100.00% <ø> (ø)
src/compile_cache.cc 77.14% <ø> (ø)
src/cppgc_helpers.h 84.21% <ø> (ø)
src/env.cc 85.47% <ø> (ø)
src/histogram.cc 73.52% <100.00%> (ø)
src/module_wrap.cc 75.97% <ø> (-0.56%) ⬇️
src/node.cc 73.75% <ø> (ø)
src/node_messaging.cc 84.19% <ø> (+0.18%) ⬆️
src/node_task_runner.cc 89.38% <ø> (ø)
src/quic/endpoint.h 72.41% <ø> (ø)
... and 6 more

... and 35 files with indirect coverage changes

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants