tools: fix typos #55061
tools: fix typos #55061
Conversation
|
Review requested:
|
nodejs-github-bot
added
build
| @@ -1040,7 +1040,7 @@ def ParseNolintSuppressions(filename, raw_line, linenum, error): | |||
| 'Unknown NOLINT error category: %s' % category) | |||
|
|
|||
|
|
|||
| def ProcessGlobalSuppresions(lines): | |||
| def ProcessGlobalSuppressions(lines): | |||
There was a problem hiding this comment.
This should be upstreamed https://github.com/cpplint/cpplint/blob/b29d3ee08e5ba1585506f220e588e2d2907f3bf7/cpplint.py#L1114
There was a problem hiding this comment.
In the upstream, it looks like they redirect the typo to the correct function
| @@ -7410,7 +7410,7 @@ var require_client = __commonJS({ | |||
| throw new InvalidArgumentError("allowH2 must be a valid boolean value"); | |||
| } | |||
| if (maxConcurrentStreams != null && (typeof maxConcurrentStreams !== "number" || maxConcurrentStreams < 1)) { | |||
| throw new InvalidArgumentError("maxConcurrentStreams must be a possitive integer, greater than 0"); | |||
| throw new InvalidArgumentError("maxConcurrentStreams must be a positive integer, greater than 0"); | |||
There was a problem hiding this comment.
Changes to github_reporter should be upstreamed to https://github.com/MoLow/reporters
There was a problem hiding this comment.
Sure, not having much luck finding it though... https://github.com/search?q=repo%3AMoLow%2Freporters%20possitive&type=code
| @@ -34,7 +34,7 @@ See [Testing](Testing.md) for more details on the test framework. | |||
| Note that it can be handy to look at the project files output by the tests | |||
| to diagnose problems. The easiest way to do that is by kindly asking the | |||
| test driver to leave the temporary directories it creates in-place. | |||
| This is done by setting the enviroment variable "PRESERVE", e.g. | |||
| This is done by setting the environment variable "PRESERVE", e.g. | |||
There was a problem hiding this comment.
Changes to gyp should be upstreamed to gyp-next
There was a problem hiding this comment.
Done! Gave it the full treatment... nodejs/gyp-next#267
Just thought I'd contribute some typo fixes that I stumbled on. Nothing controversial (hopefully).
Use the following command to get a quick summary of the specific corrections made:
FWIW, the top typos are: