Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deflake test-inspector-strip-types #55058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 22, 2024

Use the NodeRuntime.waitingForDebugger event.

Refs: #51560

Use the `NodeRuntime.waitingForDebugger` event.

Refs: nodejs#51560
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2024
@lpinca
Copy link
Member Author

lpinca commented Sep 22, 2024

Fixes https://ci.nodejs.org/job/node-test-commit-linuxone/46006/nodes=rhel9-s390x/testReport/junit/(root)/parallel/test_inspector_strip_types/

---
duration_ms: 15234.513
exitcode: 1
severity: fail
stack: |-
  [test] Connecting to a child Node process
  [test] Testing /json/list
  [err] Debugger listening on ws://127.0.0.1:42023/4731393b-b955-4019-8f07-0182e30cf571
  [err] For help, see: https://nodejs.org/en/docs/inspector
  [err]
  [err] Debugger attached.
  [err]
  Timed out waiting for matching notification ((notification) => {
      if (notification.method !== 'Debugger.scriptParsed') return false;

      return notification.params.url === scriptPath;
    })
  1
...

Before:

$ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js 
=== release test-inspector-strip-types ===                   
Path: parallel/test-inspector-strip-types
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:49443/ea1dd0d0-5c93-4ca6-9fd1-a73e017800bb
[err] For help, see: https://nodejs.org/en/docs/inspector
[err] 
[err] Debugger attached.
[err]
Timed out waiting for matching notification ((notification) => {
    if (notification.method !== 'Debugger.scriptParsed') return false;

    return notification.params.url === scriptPath;
  })
1
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js


...


[00:53|% 100|+ 993|-   7]: Done                              

Failed tests:
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js

After:

$ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js 
[00:45|% 100|+ 1000|-   0]: Done                             

All tests passed.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (cfe58cf) to head (d1f4a31).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55058   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         652      652           
  Lines      183912   183912           
  Branches    35865    35868    +3     
=======================================
+ Hits       162272   162275    +3     
  Misses      14915    14915           
+ Partials     6725     6722    -3     

see 38 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants