Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove lib/internal/idna.js #55050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: remove lib/internal/idna.js #55050

wants to merge 1 commit into from
+1 −6

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 21, 2024

We don't need this extra file. Let's remove it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels Sep 21, 2024
@RedYetiDev RedYetiDev added the lib / src Issues and PRs related to general changes in the lib or src directory. label Sep 21, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (cfe58cf) to head (22d963c).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55050      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files         652      651       -1     
  Lines      183912   183908       -4     
  Branches    35865    35871       +6     
==========================================
+ Hits       162272   162287      +15     
+ Misses      14915    14901      -14     
+ Partials     6725     6720       -5
Files with missing lines Coverage Δ
lib/url.js 100.00% <100.00%> (ø)

... and 30 files with indirect coverage changes

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62655/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62657/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62660/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
commit-queue Add this label to land a pull request using GitHub Actions. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @jasnell @lpinca @atlowChemi @RedYetiDev