Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #55029

Merged
merged 1 commit into from
Sep 22, 2024
Merged

test,crypto: update WebCryptoAPI WPT #55029

merged 1 commit into from
Sep 22, 2024
+405 −328

Conversation

panva
Copy link
Member

@panva panva commented Sep 20, 2024

Just git node wpt WebCryptoAPI.

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto web-standards Issues and PRs related to Web APIs labels Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62603/

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (d5c29ba) to head (0816051).
Report is 97 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55029      +/-   ##
==========================================
- Coverage   88.06%   88.03%   -0.04%     
==========================================
  Files         652      652              
  Lines      183546   183797     +251     
  Branches    35860    35861       +1     
==========================================
+ Hits       161648   161801     +153     
- Misses      15149    15243      +94     
- Partials     6749     6753       +4

see 50 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 21, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62619/ 💛

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2024
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0e187e4 into nodejs:main Sep 22, 2024
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0e187e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @jasnell @lpinca @jakecastelli