Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.7.0 proposal #54452

Merged
merged 157 commits into from
Aug 22, 2024
Merged
Changes from 1 commit
Commits
Show all changes
157 commits
Select commit Hold shift + click to select a range
d52f515
crypto: include NODE_EXTRA_CA_CERTS in all secure contexts by default
ebickle Sep 5, 2022
8b35f0e
tools: update eslint to 9.8.0
nodejs-github-bot Jul 30, 2024
267cd7f
path: use the correct name in `validateString`
bpasero Jul 30, 2024
019ebf0
buffer: use faster integer argument check
ronag Jul 30, 2024
037672f
url: improve resolveObject with ObjectAssign
EarlyRiser42 Jul 31, 2024
923195b
doc: clarify `useCodeCache` setting for cross-platform SEA generation
debbs061 Jul 31, 2024
826edc4
doc: expand troubleshooting section
lirantal Jul 31, 2024
33633ee
meta: add typescript team to codeowners
marco-ippolito Jul 31, 2024
b52c2ff
src: account for OpenSSL unexpected version
codebytere Jul 31, 2024
af99ba3
doc: remove unused imports from worker_threads.md
debbs061 Jul 31, 2024
2a6a12e
stream: throw TypeError when criteria fulfilled in getIterator
jakecastelli Aug 1, 2024
13cc480
module: remove outdated comment
targos Aug 1, 2024
a4aecd2
typings: add missing binding function `writeFileUtf8()`
pluris Aug 1, 2024
9f8f26e
buffer: use native copy impl
ronag Aug 2, 2024
7772b46
doc: update list of Triagers on the `README.md`
aduh95 Aug 2, 2024
98fed76
build: add `--without-amaro` build flag
aduh95 Aug 2, 2024
1cafefd
doc: fix worker threadId/destination typo
tlhunter Aug 2, 2024
5dbff81
test: add coverage for webstorage quota
jakecastelli Jul 20, 2024
9ee4b16
lib: rewrite AsyncLocalStorage without async_hooks
Qard Aug 2, 2024
db3b0df
doc: add missing new lines to custom test reporter examples
EddieAbbondanzio Aug 3, 2024
8c9a4ae
lib,permission: support Buffer to permission.has
RafaelGSS Aug 3, 2024
ab6fae9
buffer: faster type check
ronag Aug 3, 2024
1a15f3f
test: add initial pull delay and prototype pollution prevention tests
sonsurim Aug 3, 2024
670c796
test: fix typo in test
sonsurim Aug 4, 2024
db0a80a
benchmark: use assert.ok instead of assert
RafaelGSS Aug 4, 2024
11fdaa6
doc: add documentation for blob.bytes() method
jmsb02 Jul 30, 2024
20a01fc
test_runner: run after hooks even if test is aborted
cjihrig Aug 4, 2024
358fdac
doc: refresh instructions for building node from source
lirantal Aug 4, 2024
37631f8
buffer: add JSDoc to blob bytes method
RobertoSimonini1 Aug 5, 2024
425b956
lib: fix typos in comments within internal/streams
MCprotein Aug 5, 2024
5a1afb2
test_runner: remove outdated comment
cjihrig Jul 31, 2024
e218b7c
tools: add strip-types to label system
marco-ippolito Aug 5, 2024
4d8b53e
watch: reload changes in contents of --env-file
marekpiechut Aug 5, 2024
9297d29
stream: make checking pendingcb on WritableStream backward compatible
jakecastelli Aug 5, 2024
1e82591
inspector: provide detailed info to fix DevTools frontend errors
cola119 Aug 5, 2024
e619133
src: move spkac methods to ncrypto
jasnell Jul 21, 2024
144637e
doc: move release key for Myles Borins
richardlau Aug 5, 2024
7c305a4
doc, meta: replace command with link to keys
RedYetiDev Aug 5, 2024
31adeea
sea: don't set code cache flags when snapshot is used
joyeecheung Aug 5, 2024
8daeccf
src: shift more crypto impl details to ncrypto
jasnell Jul 24, 2024
5175903
doc: move `onread` option from `socket.connect()` to `new net.socket()`
sendoru Aug 5, 2024
9bbd85e
meta: bump `ossf/scorecard-action` from 2.3.3 to 2.4.0
dependabot[bot] Aug 5, 2024
6a9f168
meta: bump `github/codeql-action` from 3.25.11 to 3.25.15
dependabot[bot] Aug 6, 2024
b733854
meta: bump `actions/setup-node` from 4.0.2 to 4.0.3
dependabot[bot] Aug 6, 2024
dede30a
meta: bump `step-security/harden-runner` from 2.8.1 to 2.9.0
dependabot[bot] Aug 6, 2024
acc5b9a
meta: bump actions/setup-python from 5.1.0 to 5.1.1
dependabot[bot] Aug 1, 2024
7fa95d2
meta: bump `actions/download-artifact` from 4.1.7 to 4.1.8
dependabot[bot] Aug 6, 2024
0157ec6
meta: bump `actions/upload-artifact` from 4.3.3 to 4.3.4
dependabot[bot] Aug 6, 2024
103e4db
deps: update simdutf to 5.3.1
nodejs-github-bot Aug 6, 2024
1597a11
deps: update undici to 6.19.5
nodejs-github-bot Aug 6, 2024
350e699
build: support `lint-js-fix` in `vcbuild.bat`
RedYetiDev Aug 6, 2024
be61793
test: update wpt test for streams
Nahee-Park Aug 6, 2024
88aef5a
doc: add links to security steward companies
RedYetiDev Aug 6, 2024
dafe975
test: set test-structuredclone-jstransferable non-flaky
StefanStojanovic Aug 6, 2024
2f5309f
doc: fix sea assets example
Sadzurami Aug 6, 2024
dc46573
test_runner: make mock_loader not confuse CJS and ESM resolution
syi0808 Aug 6, 2024
8a770cf
path: fix relative on Windows
huseyinacacak-janea Aug 6, 2024
4bfa7d8
doc: add esm examples to node:console
mfdebian Aug 6, 2024
0429b1e
doc: add KevinEady as a triager
legendecas Aug 6, 2024
3835131
tools: add workflow to ensure `README` lists are in sync with gh teams
aduh95 Aug 6, 2024
a5a320c
benchmark: remove force option as force defaults to true
debbs061 Aug 6, 2024
6bcbfcd
test: add subtests to test-node-run
sungpaks Aug 6, 2024
ef9a950
deps: update acorn to 8.12.1
nodejs-github-bot Jun 16, 2024
4dd229f
benchmark: support --help in CLI
RedYetiDev Aug 6, 2024
3f0d734
meta: add module label for the lib/internal/modules folder
RedYetiDev Aug 6, 2024
e3e2f22
doc: add esm examples to node:dns
mfdebian Aug 6, 2024
783322f
lib: fix unhandled errors in webstream adapters
indutny Aug 6, 2024
112228c
fs: remove unnecessary option argument validation
JonasBa Aug 6, 2024
b85b13b
test: use assert.{s,deepS}trictEqual()
lpinca Aug 6, 2024
55f8ac3
doc: make some parameters optional in `tracingChannel.traceCallback`
deokjinkim Jul 27, 2024
581c155
meta: move one or more collaborators to emeritus
nodejs-github-bot Aug 7, 2024
b93c6d9
tools: make undici updater build wasm from src
mhdawson Jul 31, 2024
a394219
src: skip inspector wait in internal workers
legendecas Aug 7, 2024
7fad771
test_runner: fix erroneous diagnostic warning when only: false
pmarchini Aug 8, 2024
3106149
doc: warn for windows build bug
jazelly Aug 8, 2024
f5cfa44
test: refactor `test-runner-module-mocking`
aduh95 Aug 8, 2024
2f68a74
test: fix timeout not being cleared
Isaac-yz-Liu Aug 9, 2024
1ba2000
module: refactor ts parser loading
marco-ippolito Aug 9, 2024
971b9f3
doc: update `buffer.constants.MAX_LENGTH` size
samuliasmala Aug 9, 2024
a476837
typings: add util.styleText type definition
RafaelGSS Aug 9, 2024
b897057
lib: improve async_context_frame structure
Qard Aug 9, 2024
b0c768d
deps: update undici to 6.19.7
nodejs-github-bot Aug 9, 2024
37960a6
console: use validateOneOf for colorMode validation
rayark1 Aug 10, 2024
e676d98
module,win: fix long path resolve
huseyinacacak-janea Aug 10, 2024
1be0ee7
benchmark: change assert() to assert.ok()
RafaelGSS Aug 10, 2024
26c37f7
doc: remove module-based permission doc
RafaelGSS Aug 10, 2024
c8e358c
meta: add test-permission-* CODEOWNERS
RafaelGSS Aug 10, 2024
1535469
doc: explicitly mention node:fs module restriction
RafaelGSS Aug 10, 2024
c166036
benchmark: rename count to n
RafaelGSS Aug 10, 2024
e0d503a
deps: update nbytes to 0.1.1
nodejs-github-bot Aug 10, 2024
d83421f
tty: initialize winSize array with values
targos Aug 11, 2024
911de7d
inspector: support `Network.loadingFailed` event
cola119 Aug 11, 2024
869da20
deps: update c-ares to v1.33.0
nodejs-github-bot Aug 11, 2024
a2a4155
deps: fix GN build warning in ncrypto
zcbenz Aug 11, 2024
6f986e0
doc, test: simplify test README table
RedYetiDev Aug 11, 2024
6f4b5d9
doc: add esm examples to node:http2
mfdebian Aug 11, 2024
09f411e
lib: avoid for of loop and remove unnecessary variable in zlib
MCprotein Aug 12, 2024
35722b7
deps: update simdjson to 3.10.0
nodejs-github-bot Aug 12, 2024
fe7e6c9
deps: update zlib to 1.3.0.1-motley-887bb57
nodejs-github-bot Jun 16, 2024
758c9df
deps: update zlib to 1.3.0.1-motley-e432200
nodejs-github-bot Jun 23, 2024
713ae95
deps: update zlib to 1.3.0.1-motley-8b7eff8
nodejs-github-bot Jun 30, 2024
e7db639
deps: update zlib to 1.3.0.1-motley-68e57e6
nodejs-github-bot Jul 7, 2024
d0c23f3
deps: update zlib to 1.3.0.1-motley-c2469fd
nodejs-github-bot Jul 14, 2024
18bfea5
deps: update zlib to 1.3.0.1-motley-71660e1
nodejs-github-bot Aug 4, 2024
417120a
lib: replace spread operator with primordials function
MCprotein Aug 12, 2024
100225f
module: do not attempt to strip type when there's no source
aduh95 Aug 12, 2024
51b8576
benchmark: add stream.compose benchmark
jakecastelli Aug 12, 2024
94e2ea6
sqlite: ensure statement finalization on db close
cjihrig Aug 6, 2024
7f1bf1c
sqlite: split up large test file
cjihrig Jul 24, 2024
f49f1bb
test: unmark test-sqlite as flaky
cjihrig Aug 6, 2024
0bed600
url: modify pathToFileURL to handle extended UNC path
EarlyRiser42 Aug 12, 2024
8a8d1d2
doc: mark process.nextTick legacy
marco-ippolito Aug 12, 2024
b6927dd
src: move some X509Certificate stuff to ncrypto
jasnell Aug 5, 2024
0d716ad
deps: update simdutf to 5.3.4
nodejs-github-bot Aug 13, 2024
b659fc0
tools: add find pyenv path on windows
marco-ippolito Aug 13, 2024
2be78b0
src,test: ensure that V8 fast APIs are called
targos Aug 13, 2024
fe793a6
test_runner: do not expose internal loader
aduh95 Aug 13, 2024
f7f7b0c
buffer: optimize for common encodings
ronag Aug 13, 2024
6aa1d9e
build: update `ruff` to `0.5.2`
RedYetiDev Aug 13, 2024
f87aa27
src: don't match after `--` in `Dotenv::GetPathFromArgs`
RedYetiDev Aug 13, 2024
3e25be7
test: use relative paths in test-cli-permission tests
sendoru Aug 14, 2024
66dcb2a
module: unflag detect-module
GeoffreyBooth Jul 20, 2024
9aec536
path: change `posix.join` to use array
HBSPS Aug 14, 2024
1278555
buffer: optimize createFromString
ronag Aug 14, 2024
3df7938
test: make sure current run result is pushed and reset
jakecastelli Aug 14, 2024
676bbd5
test_runner: fix delete test file cause dependency file not watched
jakecastelli Aug 14, 2024
df428ad
tools: remove header from c-ares license
RedYetiDev Aug 14, 2024
c640a2f
build: always disable strict aliasing
targos Aug 14, 2024
c6544ff
benchmark: use assert.ok searchparams
RafaelGSS Aug 14, 2024
28ca678
buffer: optimize byteLength for common encodings
ronag Aug 14, 2024
409d9eb
src: shift even moar x509 to ncrypto
jasnell Aug 7, 2024
4e4d1de
src: refactor http parser binding initialization
joyeecheung Aug 14, 2024
7b641bc
buffer: optimize byteLength for short strings
ronag Aug 14, 2024
a5a60e6
buffer: use fast API for writing one-byte strings
ronag Aug 15, 2024
4b099ce
doc: fix typo in method name in the sea doc
firecraftgaming Aug 15, 2024
aa6e770
doc: correct peformance entry types
jazelly Aug 15, 2024
e3378f0
test_runner: use run() argument names in parseCommandLine()
cjihrig Aug 7, 2024
1e88045
test_runner: pass harness object as option to root test
cjihrig Aug 8, 2024
ed1ede8
test_runner: pass global options to createTestTree()
cjihrig Aug 12, 2024
69c78ca
test_runner: return setup() from parseCommandLine()
cjihrig Aug 13, 2024
961cbf0
test_runner: refactor hook creation
cjihrig Aug 13, 2024
7766c1d
test_runner: remove parseCommandLine() from test.js
cjihrig Aug 13, 2024
0b16af1
src,test: track `URL.canParse` fast API calls
targos Aug 15, 2024
8ba53ae
buffer: properly apply dst offset and src length on fast path
ronag Aug 15, 2024
33795cf
doc: replace v19 mention in Current release
RafaelGSS Aug 15, 2024
824bd58
doc: add versions when `--watch-preserve-output` was added
theoludwig Aug 16, 2024
1ca598c
cli: allow `--test-[name/skip]-pattern` in `NODE_OPTIONS`
RedYetiDev Aug 16, 2024
7f68cc0
test: make snapshot comparison more flexible
codebytere Aug 16, 2024
8883c01
doc: add note on weakness of permission model
tniessen Aug 17, 2024
f967ab3
doc: add git node security --cleanup
RafaelGSS Aug 17, 2024
9f115ba
doc: fix error description of the max header size
erm1116 Aug 18, 2024
e70711e
test_runner: report failures in filtered suites
cjihrig Aug 18, 2024
141e9fe
test_runner: use validateStringArray for `timers.enable()`
deokjinkim Aug 19, 2024
e077ff1
src: update compile cache storage structure
joyeecheung Aug 19, 2024
b6a3e61
deps: update amaro to 0.1.6
nodejs-github-bot Aug 14, 2024
240d929
module: add --experimental-transform-types flag
marco-ippolito Aug 12, 2024
65eff1e
2024-08-22, Version 22.7.0 (Current)
RafaelGSS Aug 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
path: change posix.join to use array
Change posix.join to use array.join instead of additional assignment.

PR-URL: #54331
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
  • Loading branch information
HBSPS authored and RafaelGSS committed Aug 19, 2024
commit 9aec5360837f4ecdc78d200d19029c016579b96e
14 changes: 7 additions & 7 deletions lib/path.js
Original file line number Diff line number Diff line change
Expand Up @@ -1236,20 +1236,20 @@ const posix = {
join(...args) {
if (args.length === 0)
return '.';
let joined;

const path = [];
for (let i = 0; i < args.length; ++i) {
const arg = args[i];
validateString(arg, 'path');
if (arg.length > 0) {
if (joined === undefined)
joined = arg;
else
joined += `/${arg}`;
path.push(arg);
}
}
if (joined === undefined)

if (path.length === 0)
return '.';
return posix.normalize(joined);

return posix.normalize(ArrayPrototypeJoin(path, '/'));
},

/**
Expand Down