-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: move more crypto code to ncrypto #54320
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Aug 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-bio-to-ncrypto
branch
from
August 11, 2024 22:52
ca3dbce
to
b43b4d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 11, 2024
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-bio-to-ncrypto
branch
from
August 14, 2024 21:39
b43b4d6
to
72f97e3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
crypto
Issues and PRs related to the crypto subsystem.
c++
Issues and PRs that require attention from people who are familiar with C++.
labels
Aug 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-bio-to-ncrypto
branch
from
August 15, 2024 18:12
72f97e3
to
db3cbaa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-bio-to-ncrypto
branch
from
August 15, 2024 21:48
db3cbaa
to
e3fb862
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 18, 2024
jasnell
added a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54320 Reviewed-By: Yagiz Nizipli <[email protected]>
Landed in 561bc87 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
PR-URL: #54320 Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More to ncrypto