doc: add KevinEady as a triager #54179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Aug 3, 2024
RedYetiDev
added
the
meta
|
@KevinEady is it something that you'd be interested in? |
vmoroz
approved these changes
Aug 6, 2024
|
+1. |
aymen94
approved these changes
Aug 6, 2024
|
Hi @aduh95 , Yes, absolutely. My knowledge of the Node.js architecture is pretty narrow to node-addon-api (and a little less so, the underlying Node-API) but I do contribute in what ways I can (see: PR search) 😄 I've taken a look at the triaging guide and those responsibilities look good to me. Thanks, Kevin |
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 277ed9f |
|
Yay! |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54179 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #54179 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir Morozov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to nominate @KevinEady a triager. Kevin has contributed to node-addon-api for a long time and I believe his help will be beneficial to the work in the core repo as well.
/cc @nodejs/node-api