Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotenv: fix env-file parsing #54158

Closed
wants to merge 1 commit into from
Closed

dotenv: fix env-file parsing #54158

wants to merge 1 commit into from

Conversation

lubosmato
Copy link

This PR makes parsing of env-file identical to dotenv npm package. Solves #54134

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 1, 2024
anonrig
anonrig requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently moved away from std::regex due to several reasons. #52406

@targos
Copy link
Member

targos commented Aug 1, 2024

We also can't accept a fix without tests that validate it.

@lubosmato lubosmato marked this pull request as draft August 1, 2024 17:00
@lubosmato lubosmato closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig requested changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lubosmato @targos @anonrig @nodejs-github-bot