buffer: add JSDoc to blob bytes method #54117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54117 +/- ##
==========================================
- Coverage 87.08% 87.07% -0.02%
==========================================
Files 643 643
Lines 181581 181584 +3
Branches 34897 34885 -12
==========================================
- Hits 158122 158106 -16
- Misses 16747 16754 +7
- Partials 6712 6724 +12
|
RobertoSimonini1
force-pushed
the
blob_bytes_method_JSDoc
branch
2 times, most recently
from
033f174
to
db5b2a2
Compare
jakecastelli
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
LGTM with a nit: the commit message needs to be fixed before this PR can land, please read the guideline here
My suggested commit message is: buffer: add JSDoc to blob bytes method, you can amend the commit and do a force push.
RobertoSimonini1
force-pushed
the
blob_bytes_method_JSDoc
branch
from
db5b2a2
to
50f9bde
Compare
|
@jakecastelli, ok thanks a lot for the guidance, I changed the commit message and now should be ok, if there is something else to fix let me know and I'll fix it asap, thanks again :) |
RobertoSimonini1
changed the title
github-actions
bot
removed
the
request-ci
jakecastelli
approved these changes
Aug 4, 2024
jakecastelli
added
the
author ready
trivikr
approved these changes
Aug 4, 2024
jakecastelli
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a3cd290 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54117 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #54117 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added JSDoc comment that describes the return type of the types blob method.
This fixes part of: #54105