-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: fix typos in comments within internal/streams #54093
Conversation
fixed typos in comments within the internal/streams directory.
Review requested:
|
fixed typos in comments within the internal/streams directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54093 +/- ##
==========================================
- Coverage 87.07% 87.05% -0.02%
==========================================
Files 643 643
Lines 181583 181583
Branches 34886 34876 -10
==========================================
- Hits 158114 158083 -31
- Misses 16751 16771 +20
- Partials 6718 6729 +11
|
@mcollina |
Commit Queue failed- Loading data for nodejs/node/pull/54093 ✔ Done loading data for nodejs/node/pull/54093 ----------------------------------- PR info ------------------------------------ Title lib: fix typos in comments within internal/streams (#54093) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MCprotein:fix/typo -> nodejs:main Labels stream, author ready Commits 2 - lib: fix typos in comments within internal/streams - lib: fix typos in comments within internal/streams Committers 1 - MCprotein <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jul 2024 05:31:10 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54093#pullrequestreview-2203971053 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54093#pullrequestreview-2204037355 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54093#pullrequestreview-2205074194 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10174706907 |
I will just re-request ci as there were some issues with windows build - nodejs/build#3848 |
Commit Queue failed- Loading data for nodejs/node/pull/54093 ✔ Done loading data for nodejs/node/pull/54093 ----------------------------------- PR info ------------------------------------ Title lib: fix typos in comments within internal/streams (#54093) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MCprotein:fix/typo -> nodejs:main Labels stream, author ready, needs-ci Commits 2 - lib: fix typos in comments within internal/streams - lib: fix typos in comments within internal/streams Committers 1 - MCprotein <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jul 2024 05:31:10 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54093#pullrequestreview-2203971053 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54093#pullrequestreview-2204037355 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54093#pullrequestreview-2205074194 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54093#pullrequestreview-2217298130 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-04T12:24:09Z: https://ci.nodejs.org/job/node-test-pull-request/60865/ - Querying data for job/node-test-pull-request/60865/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 54093 From https://github.com/nodejs/node * branch refs/pull/54093/merge -> FETCH_HEAD ✔ Fetched commits as c6cf313bca11..1d5286845a69 -------------------------------------------------------------------------------- [main 3256e5c140] lib: fix typos in comments within internal/streams Author: MCprotein <[email protected]> Date: Mon Jul 29 13:42:48 2024 +0900 4 files changed, 4 insertions(+), 4 deletions(-) [main 048b07ea25] lib: fix typos in comments within internal/streams Author: MCprotein <[email protected]> Date: Mon Jul 29 15:03:36 2024 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/10240488109 |
Landed in e6ee6e2 |
@jakecastelli @daeyeon thank you! |
fixed typos in comments within the internal/streams directory. PR-URL: #54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
fixed typos in comments within the internal/streams directory. PR-URL: #54093 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
fixed typos in comments within the internal/streams directory.