Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x] module: bootstrap module loaders in shadow realm #51239

Closed
wants to merge 6 commits into from
Closed

[v20.x] module: bootstrap module loaders in shadow realm #51239

wants to merge 6 commits into from

Commits on Dec 20, 2023

  1. src: make process binding data weak 

    Avoid the realm being strongly referenced by the process binding data.

PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    dd5dd67 View commit details
    Browse the repository at this point in the history

  2. src: create worker per isolate properties 

    PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f09515b View commit details
    Browse the repository at this point in the history

  3. src: create fs_dir per isolate properties 

    PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    84af29b View commit details
    Browse the repository at this point in the history

  4. src: create per isolate proxy env template 

    PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    afa56f1 View commit details
    Browse the repository at this point in the history

  5. module: remove useCustomLoadersIfPresent flag 

    The flag is always true and can be determined by isLoaderWorker solely.

PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    25d434c View commit details
    Browse the repository at this point in the history

  6. module: bootstrap module loaders in shadow realm 

    This bootstraps ESM loaders in the ShadowRealm with
`ShadowRealm.prototype.importValue` as its entry point and enables
loading ESM and CJS modules in the ShadowRealm. The module is imported
without a parent URL and resolved with the current process's working
directory.

PR-URL: nodejs#48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
    @legendecas
    legendecas committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    401dfc2 View commit details
    Browse the repository at this point in the history