Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix notify-on-push Slack messages #47453

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 6, 2023

The @here mention was not working. Also saying the commit is "lacking the expected metadata" is not always true, as lacking metadata is one of several things the workflow is checking.

Refs: https://api.slack.com/reference/surfaces/formatting#special-mentions

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@aduh95 aduh95 requested a review from debadree25 April 6, 2023 15:08
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 6, 2023
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 6, 2023
@@ -51,7 +51,7 @@ jobs:
if: ${{ env.PR_ID }}
run: |
gh pr comment ${{ env.PR_ID }} --repo "${{ github.repository }}" \
--body "A commit referencing this Pull Request was pushed to `main` by @${{ github.actor }} without the expected commit metadata added to its message."
--body "A commit referencing this Pull Request was pushed to `${{ github.ref_name }}` by @${{ github.actor }} with an invalid commit message."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Would it be better to say that the commit message failed linting and/or that it is in an invalid format rather than saying "invalid commit message"?

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 57caf13 into nodejs:main Apr 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 57caf13

RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants