Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-permission-deny-fs-wildcard (win32) #47095

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix test-permission-deny-fs-wildcard (win32)
The test fails on Windows when the working directory is not on a 'C:'
drive. For example, it always fails during the coverage-windows GitHub
action, which runs tests on drive 'D:'.

Fixes: #47093
  • Loading branch information
tniessen committed Mar 14, 2023
commit 0e42c4c4c4c3566e397ae2f110078b0ea4ef7302
33 changes: 18 additions & 15 deletions test/parallel/test-permission-deny-fs-wildcard.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,28 @@ common.skipIfWorker();

const assert = require('assert');
const fs = require('fs');
const path = require('path');

if (common.isWindows) {
const { root } = path.parse(process.cwd());
const abs = (p) => path.join(root, p);
const denyList = [
'C:\\tmp\\*',
'C:\\example\\foo*',
'C:\\example\\bar*',
'C:\\folder\\*',
'C:\\show',
'C:\\slower',
'C:\\slown',
'C:\\home\\foo\\*',
];
'tmp\\*',
'example\\foo*',
'example\\bar*',
'folder\\*',
'show',
'slower',
'slown',
'home\\foo\\*',
].map(abs);
assert.ok(process.permission.deny('fs.read', denyList));
assert.ok(process.permission.has('fs.read', 'C:\\slow'));
assert.ok(process.permission.has('fs.read', 'C:\\slows'));
assert.ok(!process.permission.has('fs.read', 'C:\\slown'));
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo'));
assert.ok(!process.permission.has('fs.read', 'C:\\home\\foo\\'));
assert.ok(process.permission.has('fs.read', 'C:\\home\\fo'));
assert.ok(process.permission.has('fs.read', abs('slow')));
assert.ok(process.permission.has('fs.read', abs('slows')));
assert.ok(!process.permission.has('fs.read', abs('slown')));
assert.ok(!process.permission.has('fs.read', abs('home\\foo')));
assert.ok(!process.permission.has('fs.read', abs('home\\foo\\')));
assert.ok(process.permission.has('fs.read', abs('home\\fo')));
} else {
const denyList = [
'/tmp/*',
Expand Down