Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: skip file: URL conversion to path when possible #46305

Merged
merged 6 commits into from
Apr 1, 2023
Merged

esm: skip file: URL conversion to path when possible #46305

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fdbd99
esm: skip file: URL conversion to path when possible
aduh95 Jan 19, 2023
e28b074
fix lint
aduh95 Mar 18, 2023
dd07383
Update lib/internal/modules/esm/get_format.js
aduh95 Mar 19, 2023
0d5e2f4
Update lib/internal/modules/esm/get_format.js
aduh95 Mar 19, 2023
51c366b
Update lib/internal/modules/esm/get_format.js
aduh95 Mar 19, 2023
f6f7fc8
use Windows-compatible URLs
aduh95 Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/modules/esm/get_format.js
  • Loading branch information
@aduh95
aduh95 committed Mar 19, 2023
commit dd073836599e16ad18fbacfbca3396baa47c952f
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/get_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const DOT_CODE = 46;
const SLASH_CODE = 47;

/**
* Returns the file extension from a file: URL. Should give similar result than
* Returns the file extension from a URL. Should give similar result to
* require('node:path').extname(require('node:url').fileURLToPath(url)).
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
* @param {URL} url A file: URL.
JakobJingleheimer marked this conversation as resolved.
Show resolved Hide resolved
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
* @returns {string}
Expand Down