Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder #44104

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

joyeecheung
Copy link
Member

To improve startup performance.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 2, 2022
@nodejs-github-bot
Copy link
Collaborator

@Hilljackcantspell

This comment was marked as off-topic.

@F3n67u F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3970c7a into nodejs:main Aug 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3970c7a

joyeecheung added a commit to joyeecheung/node that referenced this pull request Aug 5, 2022
To improve startup performance.

PR-URL: nodejs#44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request Aug 16, 2022
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
To improve startup performance.

PR-URL: #44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
To improve startup performance.

PR-URL: nodejs#44104
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants