Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add F3n67u to triagers #43350

Merged
merged 1 commit into from
Jun 11, 2022
Merged

doc: add F3n67u to triagers #43350

merged 1 commit into from
Jun 11, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 8, 2022

I volunteer to become a triager of Node.js project.

My motivation is to support our users more and make more contributions to the node community.

I have read, understand, and will adhere to the Node.js project's Code Of Conduct.

Link to PR I made: https://github.com/nodejs/node/pulls/F3n67u

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 8, 2022
Ayase-252
Ayase-252 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@Ayase-252 Ayase-252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2022
RaisinTen
RaisinTen approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@RaisinTen
Copy link
Contributor

cc @nodejs/issue-triage

VoltrexKeyva
VoltrexKeyva approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

@F3n67u
Copy link
Member Author

F3n67u commented Jun 11, 2022

Hi all! Is this pr ready to land? Is there anything else I need to do?

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 11, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43350
✔  Done loading data for nodejs/node/pull/43350
----------------------------------- PR info ------------------------------------
Title      doc: add F3n67u to triagers (#43350)
Author     Feng Yu  (@F3n67u)
Branch     F3n67u:apply-for-a-triager -> nodejs:master
Labels     doc, author ready
Commits    1
 - doc: add F3n67u to triagers
Committers 1
 - Feng Yu 
PR-URL: https://github.com/nodejs/node/pull/43350
Reviewed-By: Qingyu Deng 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Akhil Marsonya 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Darshan Sen 
Reviewed-By: Xuguang Mei 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43350
Reviewed-By: Qingyu Deng 
Reviewed-By: Rich Trott 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Akhil Marsonya 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Darshan Sen 
Reviewed-By: Xuguang Mei 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 08 Jun 2022 15:38:13 GMT
   ✔  Approvals: 9
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000001553
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000153860
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000170079
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000247159
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000315148
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000694678
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000696837
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43350#pullrequestreview-1000702516
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43350#pullrequestreview-1001044269
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2480312874

@aduh95 aduh95 merged commit 440d95a into nodejs:master Jun 11, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 11, 2022

Landed in 440d95a. Thanks for volunteering, I've also added you to @nodejs/issue-triage.

@F3n67u F3n67u deleted the apply-for-a-triager branch June 11, 2022 14:58
@F3n67u
Copy link
Member Author

F3n67u commented Jun 11, 2022

@aduh95 Invitation accepted! Thank you all! Really excited to be part of the Node.js triage team.

italojs pushed a commit to italojs/node that referenced this pull request Jun 12, 2022
@F3n67u @italojs
doc: add F3n67u to triagers
e25b2a2 
PR-URL: nodejs#43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
doc: add F3n67u to triagers
e7db3a4 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 13, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@F3n67u @danielleadams
doc: add F3n67u to triagers
adec5fa 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
doc: add F3n67u to triagers
7034178 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
doc: add F3n67u to triagers
e444279 
PR-URL: #43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
doc: add F3n67u to triagers
6157d35 
PR-URL: nodejs/node#43350
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@meixg meixg meixg approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marsonya marsonya marsonya approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.