[v16.x backport] tools: update V8 gypfiles for 9.6 #43247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
|
Should we add this to github actions ? |
targos
approved these changes
May 30, 2022
@gengjiawen what do you mean? |
cross-compile check on macOS in github actions. |
|
I think we could do that in a separate PR. |
RaisinTen
added
the
author ready
|
macOS compilation is very slow in GitHub actions. I'd prefer if we tried to do it on our own machines |
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
gengjiawen
approved these changes
May 30, 2022
|
The win-vs2019-arm64 build was failing with the same error as reported in #40488 (comment): so I also cherry-picked 4d2d44f. |
BethGriggs
approved these changes
May 31, 2022
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #40488 Backport-PR-URL: #43247 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Backport-PR-URL: #43247 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Jun 1, 2022
PR-URL: #40488 Backport-PR-URL: #43247 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Jun 1, 2022
`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: #40488 Backport-PR-URL: #43247 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Thank you!!! Landed in 447f9a0...feac215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean cherry-pick of 6ac1ccc and 4d2d44f. With this change, it
is possible to cross-compile from
x86_64toARM64on macOS.Fixes: #40350
cc @targos
Original commit messages:
tools: update V8 gypfiles for 9.6
PR-URL: deps: update V8 to 9.6 #40488
Reviewed-By: Jiawen Geng [email protected]
Reviewed-By: James M Snell [email protected]
tools: disable trap handler for Windows cross-compiler
handler-outside-simulator.ccuses inline assembly, which is notsupported by MSVC.
PR-URL: deps: update V8 to 9.6 #40488
Reviewed-By: Jiawen Geng [email protected]
Reviewed-By: James M Snell [email protected]