Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Clarify path search in child_process spawn #41418

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Commits on Jan 6, 2022

  1. doc: Clarify path search in child_process spawn

    The documentation about command lookup could be more clear and note differences between Windows and Linux/OSX.
    Current text gives the impression that if one passes `options.env` without `PATH` that the path search will fall back on `process.env.PATH`.
    However in reality, passing environment without PATH to execvp causes it to look for the binary only in `/usr/bin:/bin`.
    Also Windows behaves different and more in line with the current documentation text.
    
    References:
    https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/execvp.3.html
    https://linux.die.net/man/3/execvp
    
    https://github.com/nodejs/node/blob/c61870c376e2f5b0dbaa939972c46745e21cdbdd/deps/uv/src/unix/process.c#L337
    https://github.com/nodejs/node/blob/c61870c376e2f5b0dbaa939972c46745e21cdbdd/deps/uv/src/win/process.c#L1017
    zobo authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    5452296 View commit details
    Browse the repository at this point in the history
  2. Update doc/api/child_process.md

    Co-authored-by: Tierney Cyren <[email protected]>
    zobo and bnb authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    ac0d1bc View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Update child_process.md

    zobo authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    dbe8bcd View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Update doc/api/child_process.md

    Language fix.
    
    Co-authored-by: Rich Trott <[email protected]>
    zobo and Trott authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    591bc3d View commit details
    Browse the repository at this point in the history