Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-api: add missing initialization of last error #41290

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

  • Add missing initiatlization of last error which
    was reported by coverity.

Signed-off-by: Michael Dawson [email protected]

- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2021

Review requested:

  • @nodejs/n-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 22, 2021
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2022

Looks like CI is complete even though UI still shows one check as pending, going to land.

mhdawson added a commit that referenced this pull request Jan 4, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41290
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2022

Landed in 3f403e5

@mhdawson mhdawson closed this Jan 4, 2022
targos pushed a commit that referenced this pull request Jan 14, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41290
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41290
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#41290
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
- Add missing initiatlization of last error which
  was reported by coverity.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41290
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants