Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix internet/test-dns #40083

Closed
wants to merge 1 commit into from
Closed

test: fix internet/test-dns #40083

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 11, 2021

internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 11, 2021
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Sep 11, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott
Copy link
Member Author

Trott commented Sep 11, 2021

Only the nightly CI runs the internet tests, so this doesn't show up in our CI runs for PRs. Here it is failing in the nightly run, though: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22314/testReport/junit/(root)/test/internet_test_dns/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2021
@Trott
Copy link
Member Author

Trott commented Sep 11, 2021

Internet CI against this PR: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22318/

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Sep 11, 2021

@nodjes/testing (Also, if you review, please consider thumbs-upping the fast-track request above!)

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions
Copy link
Contributor

Landed in e267467...ec555b0

@github-actions github-actions bot closed this Sep 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2021
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
@Trott Trott deleted the fix-test-dns branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants