Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-domain-error-types flaky #39369

Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 12, 2021

Refs: #39368
Signed-off-by: James M Snell [email protected]

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 12, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 12, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell requested review from mcollina and ronag July 12, 2021 22:37
@jasnell
Copy link
Member Author

jasnell commented Jul 13, 2021

Landed in 09b57f7

@jasnell jasnell closed this Jul 13, 2021
jasnell added a commit that referenced this pull request Jul 13, 2021
Refs: #39368
Signed-off-by: James M Snell <[email protected]>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Jul 17, 2021
Refs: #39368
Signed-off-by: James M Snell <[email protected]>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Jul 26, 2021
targos pushed a commit that referenced this pull request Sep 4, 2021
Refs: #39368
Signed-off-by: James M Snell <[email protected]>

PR-URL: #39369
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants