Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: http complete list of non-concat headers #3930

Closed
wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented Nov 20, 2015

The original test was only testing some of the headers that shouldn't be concatenated as per lib/_http_incoming.js, so now the full list is there and matches what's in the docs as well.

content-length gives a ParseError if you set it to a string, so the test for that header uses numbers.

The original test was only testing some of the headers that shouldn't be
concatenated as per lib/_http_incoming.js, so now the full list is
there.

'content-length` gives a parse error if you set it to a string, so the
test for that header uses numbers.
@mscdex mscdex added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Nov 20, 2015
// Test that certain response header fields do not repeat
// Test that certain response header fields do not repeat.
// 'content-length' should also be in this list, but it needs
// a numeric header, so it's tested slightly differently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be numeric value?

@cjihrig
Copy link
Contributor

cjihrig commented Nov 20, 2015

LGTM with one tiny comment. CI: https://ci.nodejs.org/job/node-test-pull-request/797/

cjihrig pushed a commit that referenced this pull request Nov 20, 2015
The original test was only testing some of the headers that shouldn't be
concatenated as per lib/_http_incoming.js, so now the full list is
there.

'content-length` gives a parse error if you set it to a string, so the
test for that header uses numbers.

PR-URL: #3930
Reviewed-By: Colin Ihrig <[email protected]>
@cjihrig
Copy link
Contributor

cjihrig commented Nov 20, 2015

CI was a little red, but not related to this. Made the comment fix when landing.

Thanks! Landed in 174d4e4

@cjihrig cjihrig closed this Nov 20, 2015
rvagg pushed a commit that referenced this pull request Dec 5, 2015
The original test was only testing some of the headers that shouldn't be
concatenated as per lib/_http_incoming.js, so now the full list is
there.

'content-length` gives a parse error if you set it to a string, so the
test for that header uses numbers.

PR-URL: #3930
Reviewed-By: Colin Ihrig <[email protected]>
@rvagg rvagg mentioned this pull request Dec 17, 2015
@MylesBorins
Copy link
Contributor

The file this commit changes came into master as a semver major change, as such it is not part of LTS. Removing the label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants