Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: use compatible ecdh function #39054

Closed

Conversation

codebytere
Copy link
Member

Refs electron/electron#27688.

This PR switches ECDH::SetPrivateKey to use a compatible ECDH function - the previously used one is a no-op in BoringSSL. Also change an algorithm in the associated test suite to one supported by BoringSSL so we can run more smoke tests.

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 16, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

Maybe it also makes sense to add a comment here so that nobody accidentally undoes this?

@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Jun 17, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

src/crypto/crypto_ec.cc Outdated Show resolved Hide resolved
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think that's much cleaner 😃

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

Landed in 5830449

@codebytere codebytere closed this Jun 30, 2021
@codebytere codebytere deleted the use-boringssl-compat-ecdh branch June 30, 2021 08:14
codebytere added a commit that referenced this pull request Jun 30, 2021
PR-URL: #39054
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2021
PR-URL: #39054
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jul 14, 2021
jkleinsc added a commit to electron/electron that referenced this pull request Jul 15, 2021
* chore: bump node in DEPS to v16.4.2

* chore: update patches

* ci: run main and remote woa tests separately

* chore: bump node in DEPS to v16.5.0

* build: restore libplatform headers in distribution

nodejs/node#39288

* build: pass directory instead of list of files to js2c.py

nodejs/node#39069

* chore: various BoringSSL/OpenSSL upstreams

- nodejs/node#39136
- nodejs/node#39138
- nodejs/node#39054

* test: move debugger test case to parallel

nodejs/node#39300

* chore: fixup patch indices

* build: pass directory instead of list of files to js2c.py

nodejs/node#39069

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
* chore: bump node in DEPS to v16.4.2

* chore: update patches

* ci: run main and remote woa tests separately

* chore: bump node in DEPS to v16.5.0

* build: restore libplatform headers in distribution

nodejs/node#39288

* build: pass directory instead of list of files to js2c.py

nodejs/node#39069

* chore: various BoringSSL/OpenSSL upstreams

- nodejs/node#39136
- nodejs/node#39138
- nodejs/node#39054

* test: move debugger test case to parallel

nodejs/node#39300

* chore: fixup patch indices

* build: pass directory instead of list of files to js2c.py

nodejs/node#39069

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants