Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: compile with --gnu++17 #38807

Closed
wants to merge 3 commits into from
Closed

Conversation

richardlau
Copy link
Member

Enables C++17 features.

Refs: #38788

Let's see if anything breaks. Since this is in common.gypi it will affect addons as well and may introduce an incompatibility with any addons that have explicitly compiled with gnu++1z and an older (i.e. GCC 7 or earlier) version of GCC -- although using that option with those compilers is described as "highly experimental" in the GCC manual.

@richardlau richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 25, 2021
@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented May 25, 2021

Are our baseline compiler versions compatible?

@richardlau
Copy link
Member Author

Are our baseline compiler versions compatible?

We believe so, #38788 (comment).

@richardlau
Copy link
Member Author

Well this has been a useful exercise... turns out several hosts on the CI (so far SmartOS and anything on Ubuntu 18.04) are using GCC 7 even though we baselined on GCC 8 for Node.js 16.

@targos
Copy link
Member

targos commented May 25, 2021

Are our baseline compiler versions compatible?

Based on https://en.cppreference.com/w/cpp/compiler_support#cpp17, it depends on which features we are going to use, but GCC 7 already supported many of them. MSVC seems to support everything and Apple Clang most of them.

@richardlau
Copy link
Member Author

Opened nodejs/build#2660 for getting GCC 8 onto Ubuntu 18.04. Will need a separate PR for SmartOS.

@richardlau richardlau added the blocked PRs that are blocked by other issues or PRs. label May 25, 2021
@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

jasnell commented Sep 3, 2021

Definite +1 on bumping up to ++17 as soon as we can.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Sep 3, 2021

Should we do it for Windows too?

@richardlau
Copy link
Member Author

@targos Do you know what the gyp flag/setting would be? I don't think we have an existing Windows equivalent for C++14.

@richardlau
Copy link
Member Author

Do you know what the gyp flag/setting would be? I don't think we have an existing Windows equivalent for C++14.

Ah nodejs/node-gyp#1662

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2021
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member Author

🤔 I think enabling -std:c++17 on Windows has run into the same issue as #39976:
e.g. https://ci.nodejs.org/job/node-compile-windows/41950/nodes=win-vs2019/console

18:29:34   embedded-file-writer.cc
18:29:42      Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
18:29:54 mksnapshot.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: void __cdecl v8::internal::FixedArray::set(int,class v8::internal::Smi)" (?set@FixedArray@internal@v8@@QEAAXHVSmi@23@@Z) [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 ..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\mksnapshot.vcxproj]
18:29:55 

(I'm also surprised the build is linking files called -aix and -mac on Windows.)

@targos
Copy link
Member

targos commented Sep 3, 2021

I think enabling -std:c++17 on Windows has run into the same issue as #39976

Makes sense. VS 2022 probably makes it the default.

@targos
Copy link
Member

targos commented Sep 3, 2021

(I'm also surprised the build is linking files called -aix and -mac on Windows.)

That seems intended:

node/deps/v8/BUILD.gn

Lines 5311 to 5330 in f26c2ce

v8_executable("mksnapshot") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
"src/snapshot/embedded/embedded-empty.cc",
"src/snapshot/embedded/embedded-file-writer.cc",
"src/snapshot/embedded/embedded-file-writer.h",
"src/snapshot/embedded/platform-embedded-file-writer-aix.cc",
"src/snapshot/embedded/platform-embedded-file-writer-aix.h",
"src/snapshot/embedded/platform-embedded-file-writer-base.cc",
"src/snapshot/embedded/platform-embedded-file-writer-base.h",
"src/snapshot/embedded/platform-embedded-file-writer-generic.cc",
"src/snapshot/embedded/platform-embedded-file-writer-generic.h",
"src/snapshot/embedded/platform-embedded-file-writer-mac.cc",
"src/snapshot/embedded/platform-embedded-file-writer-mac.h",
"src/snapshot/embedded/platform-embedded-file-writer-win.cc",
"src/snapshot/embedded/platform-embedded-file-writer-win.h",
"src/snapshot/mksnapshot.cc",
"src/snapshot/snapshot-empty.cc",
]

@targos
Copy link
Member

targos commented Sep 5, 2021

I think a00971f needs to be rewritten somehow (I tried to revert it but get the exact same errors). /cc @gengjiawen

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 15, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 16, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 17, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 18, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 19, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 20, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 21, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 22, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 23, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 24, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 25, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 26, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 27, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 28, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 29, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 30, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Dec 31, 2022
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 1, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 2, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
targos pushed a commit that referenced this pull request Jan 2, 2023
PR-URL: #35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: #40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: #40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 2, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 4, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
targos pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: #40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: #40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: #38807
Refs: #38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 5, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 6, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 7, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Jan 7, 2023
PR-URL: nodejs#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs#38807
Refs: nodejs#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 8, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jan 9, 2023
PR-URL: nodejs/node#35415
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>

deps: patch for v8 on windows

PR-URL: nodejs/node#40010
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>

deps: patch v8 for vs2019 in std17

PR-URL: nodejs/node#40060
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>

deps: workaround debug link error on Windows

PR-URL: nodejs/node#38807
Refs: nodejs/node#38788
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants