Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: net.BlockList updates and add net.SocketAddress #37917

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
net: add SocketAddress class
Signed-off-by: James M Snell <[email protected]>
  • Loading branch information
jasnell committed Mar 30, 2021
commit 2df185595bc8be88527dae5b1dfd012ac911da2b
45 changes: 45 additions & 0 deletions doc/api/net.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,51 @@ added: v15.0.0

The list of rules added to the blocklist.

## Class: `net.SocketAddress`
<!-- YAML
added: REPLACEME
-->
### `new net.SocketAddress([options])`
<!-- YAML
added: REPLACEME
-->

* `options` {Object}
* `address` {string} The network address as either an IPv4 or IPv6 string.
**Default**: `'127.0.0.1'` if `family` is `'ipv4'`; `'::'` if `family` is
`'ipv6'`.
* `family` {string} One of either `'ipv4'` or 'ipv6'`. **Default**: `'ipv4'`.
* `flowlabel` {number} An IPv6 flow-label used only if `family` is `'ipv6'`.
* `port` {number} An IP port.

### `socketaddress.address`
<!-- YAML
added: REPLACEME
-->

* Type {string}

### `socketaddress.family`
<!-- YAML
added: REPLACEME
-->

* Type {string} Either `'ipv4'` or `'ipv6'`.

### `socketaddress.flowlabel`
<!-- YAML
added: REPLACEME
-->

* Type {number}

### `socketaddress.port`
<!-- YAML
added: REPLACEME
-->

* Type {number}

## Class: `net.Server`
<!-- YAML
added: v0.1.90
Expand Down
1 change: 1 addition & 0 deletions doc/api/worker_threads.md
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,7 @@ In particular, the significant differences to `JSON` are:
* {KeyObject}s,
* {MessagePort}s,
* {net.BlockList}s,
* {net.SocketAddress}es,
* {X509Certificate}s.

```js
Expand Down
153 changes: 153 additions & 0 deletions lib/internal/socketaddress.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
'use strict';

const {
ObjectSetPrototypeOf,
Symbol,
} = primordials;

const {
SocketAddress: _SocketAddress,
AF_INET,
AF_INET6,
} = internalBinding('block_list');

const {
validateObject,
validateString,
validatePort,
validateUint32,
} = require('internal/validators');

const {
codes: {
ERR_INVALID_ARG_VALUE,
},
} = require('internal/errors');

const {
customInspectSymbol: kInspect,
} = require('internal/util');

const { inspect } = require('internal/util/inspect');

const {
JSTransferable,
kClone,
kDeserialize,
} = require('internal/worker/js_transferable');

const kHandle = Symbol('kHandle');
const kDetail = Symbol('kDetail');

class SocketAddress extends JSTransferable {
static isSocketAddress(value) {
return value?.[kHandle] !== undefined;
}

constructor(options = {}) {
super();
validateObject(options, 'options');
const {
family = 'ipv4',
address = (family === 'ipv4' ? '127.0.0.1' : '::'),
port = 0,
flowlabel = 0,
} = options;

let type;
switch (family) {
case 'ipv4':
type = AF_INET;
break;
case 'ipv6':
type = AF_INET6;
break;
default:
throw new ERR_INVALID_ARG_VALUE('options.family', family);
}

validateString(address, 'options.address');
validatePort(port, 'options.port');
validateUint32(flowlabel, 'options.flowlabel', false);

this[kHandle] = new _SocketAddress(address, port, type, flowlabel);
this[kDetail] = this[kHandle].detail({
address: undefined,
port: undefined,
family: undefined,
flowlabel: undefined,
});
}

get address() {
return this[kDetail].address;
}

get port() {
return this[kDetail].port;
}

get family() {
return this[kDetail].family === AF_INET ? 'ipv4' : 'ipv6';
}

get flowlabel() {
// The flow label can be changed internally.
return this[kHandle].flowlabel();
}

[kInspect](depth, options) {
if (depth < 0)
return this;

const opts = {
...options,
depth: options.depth == null ? null : options.depth - 1
};

return `SocketAddress ${inspect(this.toJSON(), opts)}`;
}

[kClone]() {
const handle = this[kHandle];
return {
data: { handle },
deserializeInfo: 'internal/socketaddress:InternalSocketAddress',
};
}

[kDeserialize]({ handle }) {
this[kHandle] = handle;
this[kDetail] = handle.detail({
address: undefined,
port: undefined,
family: undefined,
flowlabel: undefined,
});
}

toJSON() {
return {
address: this.address,
port: this.port,
family: this.family,
flowlabel: this.flowlabel,
};
}
}

class InternalSocketAddress extends JSTransferable {
constructor(handle) {
super();
this[kHandle] = handle;
}
}

InternalSocketAddress.prototype.constructor =
SocketAddress.prototype.construtor;
ObjectSetPrototypeOf(InternalSocketAddress.prototype, SocketAddress.prototype);

module.exports = {
SocketAddress,
InternalSocketAddress,
};
5 changes: 5 additions & 0 deletions lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ const {
let cluster;
let dns;
let BlockList;
let SocketAddress;

const { clearTimeout } = require('timers');
const { kTimeout } = require('internal/timers');
Expand Down Expand Up @@ -1763,6 +1764,10 @@ module.exports = {
BlockList ??= require('internal/blocklist').BlockList;
return BlockList;
},
get SocketAddress() {
SocketAddress ??= require('internal/socketaddress').SocketAddress;
return SocketAddress;
},
connect,
createConnection: connect,
createServer,
Expand Down
1 change: 1 addition & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@
'lib/internal/repl/await.js',
'lib/internal/repl/history.js',
'lib/internal/repl/utils.js',
'lib/internal/socketaddress.js',
'lib/internal/socket_list.js',
'lib/internal/source_map/prepare_stack_trace.js',
'lib/internal/source_map/source_map.js',
Expand Down
2 changes: 2 additions & 0 deletions src/env.h
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ constexpr size_t kFsStatsBufferLength =
V(fingerprint256_string, "fingerprint256") \
V(fingerprint_string, "fingerprint") \
V(flags_string, "flags") \
V(flowlabel_string, "flowlabel") \
V(fragment_string, "fragment") \
V(frames_received_string, "framesReceived") \
V(frames_sent_string, "framesSent") \
Expand Down Expand Up @@ -475,6 +476,7 @@ constexpr size_t kFsStatsBufferLength =
V(script_context_constructor_template, v8::FunctionTemplate) \
V(secure_context_constructor_template, v8::FunctionTemplate) \
V(shutdown_wrap_template, v8::ObjectTemplate) \
V(socketaddress_constructor_template, v8::FunctionTemplate) \
V(streambaseoutputstream_constructor_template, v8::ObjectTemplate) \
V(qlogoutputstream_constructor_template, v8::ObjectTemplate) \
V(tcp_constructor_template, v8::FunctionTemplate) \
Expand Down
2 changes: 2 additions & 0 deletions src/node_errors.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ void OnFatalError(const char* location, const char* message);
V(ERR_CRYPTO_JOB_INIT_FAILED, Error) \
V(ERR_DLOPEN_FAILED, Error) \
V(ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE, Error) \
V(ERR_INVALID_ADDRESS, Error) \
V(ERR_INVALID_ARG_VALUE, TypeError) \
V(ERR_OSSL_EVP_INVALID_DIGEST, Error) \
V(ERR_INVALID_ARG_TYPE, TypeError) \
Expand Down Expand Up @@ -143,6 +144,7 @@ ERRORS_WITH_CODE(V)
V(ERR_DLOPEN_FAILED, "DLOpen failed") \
V(ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE, \
"Context not associated with Node.js environment") \
V(ERR_INVALID_ADDRESS, "Invalid socket address") \
V(ERR_INVALID_MODULE, "No such module") \
V(ERR_INVALID_THIS, "Value of \"this\" is the wrong type") \
V(ERR_INVALID_TRANSFER_OBJECT, "Found invalid object in transferList") \
Expand Down
Loading