Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document how to register external bindings for snapshot #37463

Closed
wants to merge 3 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Feb 21, 2021

Refs: #35711

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 21, 2021
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@juanarbol juanarbol added the doc Issues and PRs related to the documentations. label Feb 21, 2021
} // namespace util
} // namespace node

NODE_MODULE_EXTERNAL_REFERENCE(util, node::util::RegisterExternalReferences)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to also point out that util needs to be listed in the node_external_reference.h EXTERNAL_REFERENCE_BINDING_LIST_BASE macro

src/README.md Outdated Show resolved Hide resolved
joyeecheung added a commit that referenced this pull request Mar 1, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung
Copy link
Member Author

Landed in 7c63bc6

@joyeecheung joyeecheung closed this Mar 1, 2021
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
PR-URL: nodejs#37463
Refs: nodejs#35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 2, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 27, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #37463
Refs: #35711
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants