Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: deprecate KeyObject.from but support CryptoKeys in create*Key #37240

Closed
wants to merge 6 commits into from
Closed

crypto: deprecate KeyObject.from but support CryptoKeys in create*Key #37240

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b7c31b3
crypto: rename KeyObject.from to fromCryptoKey
tniessen Feb 5, 2021
1d12a20
Update doc/api/deprecations.md
tniessen Feb 5, 2021
d632cd6
crypto: allow CryptoKeys in create*Key
tniessen Feb 6, 2021
6a7a614
fixup! crypto: rename KeyObject.from to fromCryptoKey
tniessen Feb 6, 2021
0155540
fixup! crypto: allow CryptoKeys in create*Key
tniessen Feb 6, 2021
27a268f
fixup! crypto: allow CryptoKeys in create*Key
tniessen Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! crypto: allow CryptoKeys in create*Key
  • Loading branch information
@tniessen
tniessen committed Feb 6, 2021
commit 27a268f660bbdf002f8144a46bb4c0562910c426
6 changes: 5 additions & 1 deletion lib/internal/crypto/keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,11 @@ function prepareSecretKey(key, encoding, bufferOnly = false) {
}

function createSecretKey(key, encoding) {
key = prepareSecretKey(key, encoding, false);
// TODO(tniessen): This doesn't really work.
if (isCryptoKey(key))
return key[kKeyObject];

key = prepareSecretKey(key, encoding, true);
if (key.byteLength === 0)
throw new ERR_OUT_OF_RANGE('key.byteLength', '> 0', key.byteLength);
const handle = new KeyObjectHandle();
Expand Down