Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix d8 macOS build #37211

Closed
wants to merge 1 commit into from
Closed

tools: fix d8 macOS build #37211

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Feb 3, 2021

libv8_base doesn't exist anymore.

@targos
tools: fix d8 macOS build
5d19f6e 
libv8_base doesn't exist anymore.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 3, 2021
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Feb 3, 2021
@richardlau
Copy link
Member

How far back should this be backported?

@targos
Copy link
Member Author

targos commented Feb 3, 2021

I don't know, but this doesn't have to be backported, unless someone needs to build d8 on an older branch.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35975/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35979/

targos added a commit that referenced this pull request Feb 7, 2021
@targos
tools: fix d8 macOS build
907d6b6 
libv8_base doesn't exist anymore.

PR-URL: #37211
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos
Copy link
Member Author

targos commented Feb 7, 2021

Landed in 907d6b6

@targos targos closed this Feb 7, 2021
@targos targos deleted the fix-d8-macos branch February 7, 2021 14:44
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@targos @danielleadams
tools: fix d8 macOS build
eb0daae 
libv8_base doesn't exist anymore.

PR-URL: #37211
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced Feb 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @richardlau @nodejs-github-bot @evanlucas @Trott @cjihrig @gengjiawen