Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeout on ASAN Action #37007

Closed
wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 20, 2021

Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results.

Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 20, 2021
Copy link
Contributor

@ttzztztz ttzztztz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2021
@nodejs-github-bot
Copy link
Collaborator

jasnell pushed a commit that referenced this pull request Jan 24, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jan 24, 2021

Landed in 90cae3a

@jasnell jasnell closed this Jan 24, 2021
@aduh95 aduh95 deleted the asan-gh-action-timeout branch January 24, 2021 22:43
targos pushed a commit that referenced this pull request Feb 2, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 25, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 5, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jun 11, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s
per test to limit the number of false negative on GH Action CI results.

PR-URL: #37007
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants