Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use global.EventTarget instead of internals #36002

Merged
merged 1 commit into from
Nov 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/parallel/test-abortcontroller.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
// Flags: --no-warnings --expose-internals
// Flags: --no-warnings
'use strict';

const common = require('../common');

const { ok, strictEqual } = require('assert');
const { Event } = require('internal/event_target');

{
// Tests that abort is fired with the correct event type on AbortControllers
Expand Down
5 changes: 0 additions & 5 deletions test/parallel/test-eventtarget-once-twice.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
// Flags: --expose-internals --no-warnings
'use strict';
const common = require('../common');
const {
Event,
EventTarget,
} = require('internal/event_target');
const { once } = require('events');

const et = new EventTarget();
Expand Down
6 changes: 0 additions & 6 deletions test/parallel/test-eventtarget-whatwg-once.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
// Flags: --expose-internals --no-warnings
'use strict';

const common = require('../common');

const {
Event,
EventTarget,
} = require('internal/event_target');

const {
strictEqual,
} = require('assert');
Expand Down
6 changes: 1 addition & 5 deletions test/parallel/test-eventtarget.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
'use strict';

const common = require('../common');
const {
Event,
EventTarget,
defineEventHandler
} = require('internal/event_target');
const { defineEventHandler } = require('internal/event_target');

const {
ok,
Expand Down
5 changes: 1 addition & 4 deletions test/parallel/test-nodeeventtarget.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
'use strict';

const common = require('../common');
const {
Event,
NodeEventTarget,
} = require('internal/event_target');
const { NodeEventTarget } = require('internal/event_target');

const {
deepStrictEqual,
Expand Down