Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: add FileHandle support to Read/WriteStream #35922

Closed
wants to merge 20 commits into from
Closed

stream: add FileHandle support to Read/WriteStream #35922

wants to merge 20 commits into from

Commits on Dec 2, 2020

  1. stream: add FileHandle support to Read/WriteStream 

    Support creating a Read/WriteStream from a
FileHandle instead of a raw file descriptor
Add an EventEmitter to FileHandle with a single
'close' event

Refs: nodejs#35240
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    72873cf View commit details
    Browse the repository at this point in the history

  2. stream: support FileHandle in Read/WriteStream 

    Add the PR URL to the documentation

Refs: nodejs#35922
Refs: nodejs#35240
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    51640a5 View commit details
    Browse the repository at this point in the history

  3. stream: Add FileHandle support to Read/WriteStream 

    Replace the hard-coded version with REPLACEME

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    4a841ac View commit details
    Browse the repository at this point in the history

  4. stream: support FileHandle for Read/WriteStream 

    Use primordials where applicable (@aduh95)

Co-authored-by: Antoine du Hamel <[email protected]>
    @mmomtchev @aduh95
    mmomtchev and aduh95 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    6662fb3 View commit details
    Browse the repository at this point in the history

  5. stream: support FileHandle for Read/WriteStream 

    Use primordials where necessary (@aduh95) and
check that the data was actually written in the
unit test

Refs: nodejs#35922
Refs: nodejs#35240
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    7713743 View commit details
    Browse the repository at this point in the history

  6. stream: support FileHandle for Read/WriteStream 

    Add a worker unit test

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    d43eb37 View commit details
    Browse the repository at this point in the history

  7. stream: Support FileHandle in Read/WriteStream 

    Integrate latest remarks by @addaleax and
@aduh95
Create an inherited class generator for
EventEmitter
Respect alphabetical order when importing
Do not emit a second 'close' event when closing
the handle in an event handler
Test more edge cases

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    e6eba34 View commit details
    Browse the repository at this point in the history

  8. stream: Support FileHandle in Read/WriteStream 

    Include remarks by @addaleax and @aduh95
Move the double inheritance class generator to
the internal event_target
Restore deleted commas
Fix a slightly flaky test

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    7495c24 View commit details
    Browse the repository at this point in the history

  9. stream: support FileHandle in Read/WriteStream 

    Cosmetic fixes / primordials

Co-authored-by: Antoine du Hamel <[email protected]>
    @mmomtchev @aduh95
    mmomtchev and aduh95 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    be4dc0b View commit details
    Browse the repository at this point in the history

  10. fs: add FileHandle support to Read/WriteStream 

    Adopt reviewing remarks by @addaleax and @Trott

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    b9c8218 View commit details
    Browse the repository at this point in the history

  11. fs: add FileHandle support to Read/WriteStream 

    fix after rebasing

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    bb8f483 View commit details
    Browse the repository at this point in the history

  12. fs: support for FileHandle in Read/WriteStream 

    Adopt @aduh95's performance improvement

Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    9506ec8 View commit details
    Browse the repository at this point in the history

  13. stream: remove duplicate EventTarget after rebase 

    Refs: nodejs#35922
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    cb0c20c View commit details
    Browse the repository at this point in the history

  14. stream: actually run the unit test

    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    96d0198 View commit details
    Browse the repository at this point in the history

  15. stream: throw on invalid args

    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    7095132 View commit details
    Browse the repository at this point in the history

  16. stream: linting

    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    ea37dd7 View commit details
    Browse the repository at this point in the history

  17. stream: remove useless initializiation of stream.fd

    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    403a7aa View commit details
    Browse the repository at this point in the history

  18. stream: create tmpdir only in main thread 

    fix flaky test, tmpdir should be refreshed only
in the main thread
    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    c267bc1 View commit details
    Browse the repository at this point in the history

  19. Remove useless / from path.join 

    Apply suggestions from code review

Co-authored-by: Antoine du Hamel <[email protected]>
    @mmomtchev @aduh95
    mmomtchev and aduh95 committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    68f98fb View commit details
    Browse the repository at this point in the history

  20. stream: compatibility with the --work test

    @mmomtchev
    mmomtchev committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    8d0a717 View commit details
    Browse the repository at this point in the history