Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: move OutboundMessage.prototype.flush to EOL #31164

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ However, the deprecation identifier will not be modified.
### DEP0001: `http.OutgoingMessage.prototype.flush`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/31164
description: End-of-Life.
- version:
- v4.8.6
- v6.12.0
Expand All @@ -54,9 +57,9 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `OutgoingMessage.prototype.flush()` method is deprecated. Use
`OutgoingMessage.prototype.flush()` has been removed. Use
`OutgoingMessage.prototype.flushHeaders()` instead.

<a id="DEP0002"></a>
Expand Down
4 changes: 0 additions & 4 deletions lib/_http_outgoing.js
Original file line number Diff line number Diff line change
Expand Up @@ -893,10 +893,6 @@ OutgoingMessage.prototype.flushHeaders = function flushHeaders() {
this._send('');
};

OutgoingMessage.prototype.flush = internalUtil.deprecate(function() {
this.flushHeaders();
}, 'OutgoingMessage.flush is deprecated. Use flushHeaders instead.', 'DEP0001');

OutgoingMessage.prototype.pipe = function pipe() {
// OutgoingMessage should be write-only. Piping from it is disabled.
this.emit('error', new ERR_STREAM_CANNOT_PIPE());
Expand Down
37 changes: 0 additions & 37 deletions test/parallel/test-http-flush.js

This file was deleted.