Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-streams #30757

Merged
merged 1 commit into from
Dec 2, 2019
Merged

test: fix test-benchmark-streams #30757

merged 1 commit into from
Dec 2, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 2, 2019

test-benchmark-streams is currently failing because the sync option is
not specified in the test, resulting in too many benchmarks running.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 2, 2019
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

I'd like to fast-track to fix node-daily-master. Collaborators, please 👍 here to approve.

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 2, 2019
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

CI that includes benchmark tests (queued): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10564/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
@nodejs-github-bot
Copy link
Collaborator

test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: nodejs#30757
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott Trott merged commit cf3a05a into nodejs:master Dec 2, 2019
@Trott
Copy link
Member Author

Trott commented Dec 2, 2019

Landed in cf3a05a

@Trott Trott deleted the fix-streams branch December 2, 2019 14:04
targos pushed a commit that referenced this pull request Dec 3, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
targos pushed a commit that referenced this pull request Dec 5, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
test-benchmark-streams is currently failing because the `sync` option is
not specified in the test, resulting in too many benchmarks running.

PR-URL: #30757
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants