Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: remove non-existant methods from docs #30346

Conversation

SimonSchick
Copy link
Contributor

Checklist

It seems these methods are not present anymore, not even with --inspect so I propose removing these docs.

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations. labels Nov 10, 2019
@SimonSchick SimonSchick force-pushed the docs/remove-dead-inspector-methods branch from 22703ab to 1bceb10 Compare November 10, 2019 07:10
@SimonSchick SimonSchick force-pushed the docs/remove-dead-inspector-methods branch 2 times, most recently from df39117 to 8d29657 Compare November 10, 2019 07:58
@SimonSchick
Copy link
Contributor Author

Fixed lint and commit message.

@SimonSchick SimonSchick changed the title docs, lib: remove non-existant methods console: remove non-existant methods from docs Nov 10, 2019
@lpinca
Copy link
Member

lpinca commented Nov 10, 2019

@SimonSchick I think doc: is more appropriate as subsystem in commit title.

@SimonSchick
Copy link
Contributor Author

Ah, I tried to use docs before but I guess it needs to be singular.

@SimonSchick SimonSchick force-pushed the docs/remove-dead-inspector-methods branch from 8d29657 to 5e7d211 Compare November 10, 2019 08:43
@danbev
Copy link
Contributor

danbev commented Nov 12, 2019

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2019
danbev pushed a commit that referenced this pull request Nov 13, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@danbev
Copy link
Contributor

danbev commented Nov 13, 2019

Landed in 0e964a7.

@danbev danbev closed this Nov 13, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30346
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants